linux-kernel - Re: [PATCH] ALPHA: TITAN - check for allocated memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 16 May 2007 20:41:01 +0100
From:	Al Viro <viro@....linux.org.uk>
To:	Cyrill Gorcunov <gorcunov@...il.com>
Cc:	Richard Henderson <rth@...ddle.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel-list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALPHA: TITAN - check for allocated memory

On Wed, May 16, 2007 at 10:13:32PM +0400, Cyrill Gorcunov wrote:
> This patch adds checking for allocated memory
> which is used to hold AGP info. Also some whitespace
> cleanup.

Could you please not do that again?  Whitespace cleanup is nice as a separate
followup, but as it is it just obscures the real changes in patch.  Digging
out

> @@ -767,6 +767,11 @@ titan_agp_info(void)
>  	 * Allocate the info structure.
>  	 */
>  	agp = kmalloc(sizeof(*agp), GFP_KERNEL);
> +	if (agp == NULL) {
> +		printk(KERN_ERR "TITAN - cannot allocate struct of size %d bytes\n",
> +		       sizeof(*agp));
> +		return NULL;
> +	}

out of hundreds of lines in patch just makes review harder.  Incidentally,
%d is not size_t, it's int.  Use %zu, please.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/