linux-kernel - Re: [PATCH] Remove duplicate ID in ipaq driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 16 May 2007 17:36:48 -0400
From:	Ben Collins <ben.collins@...ntu.com>
To:	Roland Dreier <rdreier@...co.com>
Cc:	linux-kernel@...r.kernel.org, Linus Torvalds <torvalds@...l.org>,
	Ganesh Varadarajan <ganesh@...itas.com>,
	linux-usb-devel@...ts.sourceforge.net
Subject: Re: [PATCH] Remove duplicate ID in ipaq driver

On Wed, 2007-05-16 at 13:59 -0700, Roland Dreier wrote:
> >  	/* The first entry is a placeholder for the insmod-specified device */
>  > -	{ USB_DEVICE(0x049F, 0x0003) },
> 
> Is it obvious why this patch is correct?  Especially given the
> comment just before the line you delete, and the code
> 
> 	if (vendor) {
> 		ipaq_id_table[0].idVendor = vendor;
> 		ipaq_id_table[0].idProduct = product;
> 	}
> 
> in ipaq_init()?

My mistake, quick on the patching going through this dupe list.

Might I add that this is terrible use of the device table, though.
Clutters userspace, and adds processing to module-init-tools programs.

-- 
Ubuntu   : http://www.ubuntu.com/
Linux1394: http://wiki.linux1394.org/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/