lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 23 May 2007 18:35:52 -0700 From: Paul Jackson <pj@....com> To: Paul Menage <menage@...gle.com> Cc: akpm@...ux-foundation.org, linux-kernel@...r.kernel.org, menage@...gle.com Subject: Re: [PATCH] Reduce cpuset.c write_lock_irq() to read_lock() Paul M wrote: > cpuset.c:update_nodemask() uses a write_lock_irq() on tasklist_lock to > block concurrent forks; a read_lock() suffices and is less intrusive. Seems reasonable to me - thanks. > - write_lock_irq(&tasklist_lock); /* block fork */ > + read_lock(&tasklist_lock); /* block fork */ > if (atomic_read(&cs->count) <= ntasks) > break; /* got enough */ > - write_unlock_irq(&tasklist_lock); /* try again */ > + read_unlock(&tasklist_lock); /* try again */ Too bad you didn't keep the nicely aligned comments aligned ;). -- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson <pj@....com> 1.925.600.0401 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists