linux-kernel - Re: [patch -mm 1/1] remove useless tolower in isofs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 May 2007 03:11:04 +0000
From:	"young dave" <hidave.darkstar@...il.com>
To:	"John Anthony Kazos Jr." <jakj@...-k-j.com>
Cc:	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: Re: [patch -mm 1/1] remove useless tolower in isofs

Hi,
> And then there's the supercompact form.
>
> while (len--) {
>         hash = partial_name_hash(tolower(*name++), hash);
> }
>
> But I do not like the last one at all. The first one is the best, because
> it clearly separates the condition and iteration parts of the expression,
> while STILL being only three lines long. Or two, if you omit the braces.
> (But you shouldn't.)
>

IMO, I like the last one, but I prefer to keep the original author's
one, I only remove the unnecessary tolower function.
What do you think about this , Andrew?

Regards
dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/