lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 29 May 2007 15:49:47 +0530 From: Balbir Singh <balbir@...ux.vnet.ibm.com> To: Ingo Molnar <mingo@...e.hu> Cc: linux-kernel@...r.kernel.org, Linus Torvalds <torvalds@...ux-foundation.org>, Andrew Morton <akpm@...ux-foundation.org>, Mike Galbraith <efault@....de>, Arjan van de Ven <arjan@...radead.org>, Thomas Gleixner <tglx@...utronix.de>, pranith-kumar_d@...torg.com, Andi Kleen <andi@...stfloor.org> Subject: Re: [patch] CFS scheduler, -v14 Hi, Ingo, > +static clock_t task_utime(struct task_struct *p) > +{ > + /* > + * Use CFS's precise accounting, if available: > + */ > + if (!has_rt_policy(p) && !(sysctl_sched_load_smoothing & 128)) > + return nsec_to_clock_t(p->sum_exec_runtime); I wonder if this leads to data truncation, p->sum_exec_runtime is unsigned long long and clock_t is long (on all architectures from what my cscope shows me). I have my other patch ready on top of this. I'll post it out soon. > + > + return cputime_to_clock_t(p->utime); > +} > + -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists