linux-kernel - Re: [PATCH 23/36] drivers edac Lindent amd76x driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 3 Jun 2007 08:27:44 -0700 (PDT)
From:	Doug Thompson <norsk5@...oo.com>
To:	Simon Arlott <simon@...e.lp0.eu>
Cc:	linux-kernel@...r.kernel.org, Andrew Morton <akpm@...l.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>
Subject: Re: [PATCH 23/36] drivers edac Lindent amd76x driver


--- Simon Arlott <simon@...e.lp0.eu> wrote:

> On 03/06/07 16:11, Doug Thompson wrote:
> > Run this driver through Lindent for cleanup purposes
> >  amd76x_edac.c |   54
> >  1 file changed, 25 insertions(+), 29 deletions(-)
> > --- linux-2.6.22-rc1.orig/drivers/edac/amd76x_edac.c
> > +++ linux-2.6.22-rc1/drivers/edac/amd76x_edac.c
> > @@ -86,11 +86,9 @@ struct amd76x_dev_info {
> >  
> >  static const struct amd76x_dev_info amd76x_devs[] = {
> >  	[AMD761] = {
> > -		.ctl_name = "AMD761"
> > -	},
> > +		    .ctl_name = "AMD761"},
> >  	[AMD762] = {
> > -		.ctl_name = "AMD762"
> > -	},
> > +		    .ctl_name = "AMD762"},
> >  };
> >  
> 
> You're adding a *lot* of spaces...

Yeah, that is weird - There were 2 tabs and Lindent ADDED 4 spaces on
top of that. I understood that Lindent has problems with 'gotos',
didn't know it had issues like this one.

doug t


> 
> From CodingStyle: "Outside of comments, documentation and except in
> Kconfig, spaces are never used for indentation".
> 
> -- 
> Simon Arlott
> 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/