linux-kernel - Re: [RFC] Documentation/CodingStyle: Add rules for goto labels (-v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 4 Jun 2007 20:30:14 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Jeremy Fitzhardinge <jeremy@...p.org>,
	Jeff Garzik <jeff@...zik.org>,
	Randy Dunlap <rdunlap@...otime.net>,
	Al Viro <viro@....linux.org.uk>,
	LKML <linux-kernel@...r.kernel.org>, akpm@...ux-foundation.org,
	Chen Li-jun <cljun@...ou.edu.cn>,
	Wang Ya-gang <lazy_linux@....com>
Subject: Re: [RFC] Documentation/CodingStyle: Add rules for goto labels (-v2)

On Mon, Jun 04, 2007 at 04:19:38PM +0800, WANG Cong wrote:
> 
> Lindent gets wrong when it meets goto labels. This should be fixed manually.
> And kernel's CodingStyle doesn't specify the indentation for goto labels explicitly.
> 
> This patch adds specifications on those things about goto labels in CodingStyle. And it is
> against -rc3 source tree.
> 
> Thanks to Al Viro, Randy Dunlap, Jeff Garzik and Jeremy Fitzhardinge for their comments!
> 
> Regards!
> 
> Signed-off-by: WANG Cong <xiyou.wangcong@...il.com>
> 
> ---
>  CodingStyle |    7 +++++++
>  1 file changed, 7 insertions(+)
> 
> --- linux-2.6.22-rc3/Documentation/CodingStyle.orig	2007-06-04 15:53:58.000000000 +0800
> +++ linux-2.6.22-rc3/Documentation/CodingStyle	2007-06-04 16:04:31.000000000 +0800
> @@ -66,6 +66,13 @@ something to hide:
>  Don't put multiple assignments on a single line either.  Kernel coding style
>  is super simple.  Avoid tricky expressions.
>  
> +Do care when you use Lindent to indent your code, since it may use spaces
> +instead of tabs before a goto label and it may also align the label in a
> +wrong position. Generally speaking, a goto label should be always aligned in
> +the first column. However, it might make sense to indent a label deeper if
> +you've actually declared it local (__label__). Please fix it manually if you
> +find Lindent is wrong.

If local(__label__) really so widely used in the kernel that it deserves
a place in coding-style?
A quick grep did not say so.


	Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/