linux-kernel - Re: [PATCH] 2.4.34 - Add some ahci pci ids

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 06 Jun 2007 22:16:14 +0200
From:	Filippo Carletti <carletti@...ilia.it>
To:	Willy Tarreau <w@....eu>
CC:	Jeff Garzik <jeff@...zik.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] 2.4.34 - Add some ahci pci ids

>>> The original patch contained also this lines (that I omitted):
>>> +       /* JMicron-specific fixup: make sure we're in AHCI mode */
>>> +       if (pdev->vendor == 0x197b)
>>> +               pci_write_config_byte(pdev, 0x41, 0xa1);
>> NAK.  Don't omit obviously needed lines, if you are going to add JMicron 
>> PCI IDs.
> 
> Filippo,
> 
> would you please resend your patch including the lines you have omitted ?
> Jeff is right, those lines are explicitly labelled as a fixup, so either
> we merge the complete patch, or nothing at all.

I'm attaching a revised patch that includes JMicron fixup I missed earlier.

The patch applies but it's not tested because I lack appropriate hw.

Ciao,
Filippo

View attachment "linux-2.4.34_ahci.patch" of type "text/x-patch" (1432 bytes)