linux-kernel - Re: [KJ] Re: [PATCH] drivers/isdn/hisax: ARRAY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 11 Jun 2007 20:59:22 +0200
From:	Jan-Benedict Glaw <jbglaw@...-owl.de>
To:	Andi Drebes <lists-receive@...grammierforen.de>,
	kernel-janitors@...ts.osdl.org,
	linux-kernel <linux-kernel@...r.kernel.org>
Cc:	Darren Jenkins <darrenrjenkins@...il.com>
Subject: Re: [KJ] Re: [PATCH] drivers/isdn/hisax: ARRAY_SIZE instead of sizeof

On Mon, 2007-06-11 19:47:06 +0200, Karsten Keil <kkeil@...e.de> wrote:
> diff --git a/drivers/isdn/hisax/callc.c b/drivers/isdn/hisax/callc.c
> index 7c56c44..0b9ed8e 100644
> --- a/drivers/isdn/hisax/callc.c
> +++ b/drivers/isdn/hisax/callc.c
> @@ -834,8 +834,6 @@ static struct FsmNode fnlist[] __initdata =
>  };
>  /* *INDENT-ON* */
>  
> -#define FNCOUNT (sizeof(fnlist)/sizeof(struct FsmNode))
> -
>  int __init
>  CallcNew(void)
>  {
> @@ -843,7 +841,7 @@ CallcNew(void)
>  	callcfsm.event_count = EVENT_COUNT;
>  	callcfsm.strEvent = strEvent;
>  	callcfsm.strState = strState;
> -	return FsmNew(&callcfsm, fnlist, FNCOUNT);
> +	return FsmNew(&callcfsm, fnlist, ARRAY_SIZE(fnlist));
>  }
>  
>  void

I think that's really a nice improvement :)  Thanks for the work,

MfG, JBG

-- 
      Jan-Benedict Glaw      jbglaw@...-owl.de              +49-172-7608481
Signature of:           Ich hatte in letzter Zeit ein bißchen viel Realitycheck.
the second  :               Langsam möchte ich mal wieder weiterträumen können.
                             -- Maximilian Wilhelm (18. Mai 2006, #lug-owl.de)

Download attachment "signature.asc" of type "application/pgp-signature" (190 bytes)