linux-kernel - Re: [BUG] long freezes on thinkpad t60

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Jun 2007 20:02:58 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Miklos Szeredi <miklos@...redi.hu>, cebbert@...hat.com,
	chris@...ee.ca, linux-kernel@...r.kernel.org, tglx@...utronix.de,
	akpm@...ux-foundation.org
Subject: Re: [BUG] long freezes on thinkpad t60


* Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> > Boots and runs fine.  Fixes the freezes as well, which is not such a 
> > big surprise, since basically any change in that function seems to 
> > do that ;)
> 
> Yeah, and that code really was *designed* to make all "locking in a 
> loop" go away. So unlike the patches adding random barriers and 
> cpu_relax() calls (which might fix it for some *particular* hw setup), 
> I pretty much guarantee that you can never get that code into a 
> situation where there is some lock being starved on *any* hw setup.
> 
> Ingo, an ack for the patch, and I'll just apply it?

yeah. It's definitely better than what we had before. Maybe one day 
someone frees us from this function =B-) We already had like 2-3 nasty 
SMP bugs related to it in the last 10 years.

Acked-by: Ingo Molnar <mingo@...e.hu>

and kudos to Miklos for the patience to debug this bug!

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/