linux-kernel - Re: [PATCH] bracing the loop in kernel/softirq.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 21 Jun 2007 17:49:33 +0400
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Jesper Juhl <jesper.juhl@...il.com>
Cc:	Cyrill Gorcunov <gorcunov@...il.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] bracing the loop in kernel/softirq.c

[Jesper Juhl - Wed, Jun 20, 2007 at 11:01:44PM +0200]
| From: Jesper Juhl <jesper.juhl@...il.com>
| To: Cyrill Gorcunov <gorcunov@...il.com>
| Cc: LKML <linux-kernel@...r.kernel.org>
| Subject: Re: [PATCH] bracing the loop in kernel/softirq.c
| Date: Wed, 20 Jun 2007 23:01:44 +0200
| 
> On 20/06/07, Cyrill Gorcunov <gorcunov@...il.com> wrote:
>> This trivial patch adds braces over a one-line
>> loop. That makes code...well... little bit
>> convenient for (possible) further modifications.
>>
> That's generally not done.
>
> It's even in Documentation/CodingStyle :
>
> "
> Do not unnecessarily use braces where a single statement will do.
>
> if (condition)
>        action();
> "
>
> -- 
> Jesper Juhl <jesper.juhl@...il.com>
> Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
> Plain text mails only, please      http://www.expita.com/nomime.html
>

Hi Jasper,

look, the CodingStyle is absolutely right BUT:

	- dropping the braces are good solution for 'if' statement indeed
	- dropping the braces are _not_ good for 'do' - 'while' loop 'case
	  it fails on further loop modifications. Moreover adding these braces
	  we don't change amount of lines in code! So why souldn't we? I don't
	  see any reason not to do.

		Cyrill

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/