lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: 24 Jun 2007 17:28:39 +0200 From: Andi Kleen <andi@...stfloor.org> To: Nick Piggin <npiggin@...e.de> Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Linux Memory Management List <linux-mm@...ck.org>, linux-fsdevel@...r.kernel.org Subject: Re: [patch 1/3] add the fsblock layer Nick Piggin <npiggin@...e.de> writes: [haven't read everything, just commenting on something that caught my eye] > +struct fsblock { > + atomic_t count; > + union { > + struct { > + unsigned long flags; /* XXX: flags could be int for better packing */ int is not supported by many architectures, but works on x86 at least. Hmm, could define a macro DECLARE_ATOMIC_BITMAP(maxbit) that expands to the smallest possible type for each architecture. And a couple of ugly casts for set_bit et.al. but those could be also hidden in macros. Should be relatively easy to do. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists