lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 25 Jun 2007 23:30:12 -0700 From: Andrew Morton <akpm@...ux-foundation.org> To: "Keshavamurthy, Anil S" <anil.s.keshavamurthy@...el.com> Cc: linux-kernel@...r.kernel.org, ak@...e.de, gregkh@...e.de, muli@...ibm.com, suresh.b.siddha@...el.com, arjan@...ux.intel.com, ashok.raj@...el.com, davem@...emloft.net, clameter@....com Subject: Re: [Intel IOMMU 05/10] Intel IOMMU driver On Tue, 19 Jun 2007 14:37:06 -0700 "Keshavamurthy, Anil S" <anil.s.keshavamurthy@...el.com> wrote: > Actual intel IOMMU driver. Hardware spec can be found at: > http://www.intel.com/technology/virtualization > > This driver sets X86_64 'dma_ops', so hook into standard DMA APIs. In this way, > PCI driver will get virtual DMA address. This change is transparent to PCI > drivers. > > Changes from previous postings: > 1) Fixed all the coding style errors - checkpatches.pl passes this patch > 2) Addressed all Andrew's comments > 3) Removed resource pool ( a.k.a pre-allocate pool) > 4) Now uses the standard kmem_cache_alloc functions to allocate memory > during dma map api calls. > > > ... > +#define context_set_translation_type(c, val) \ > + do { \ > + (c).lo &= (((u64)-1) << 4) | 3; \ > + (c).lo |= ((val) & 3) << 2; \ > + } while (0) That evaluates `c' twice. It's a little handgrenade waiting to go off. > +#define context_clear_entry(c) do {(c).lo = 0; (c).hi = 0;} while (0) Ditto - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists