linux-kernel - Re: [PATCH] mmc: at91_mci: fix hanging and rework to match flowcharts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 2 Jul 2007 14:45:13 +0200
From:	Marc Pignat <marc.pignat@...s.ch>
To:	Nicolas Ferre <nicolas.ferre@....atmel.com>
Cc:	Pierre Ossman <drzeus@...eus.cx>,
	ARM Linux Mailing List 
	<linux-arm-kernel@...ts.arm.linux.org.uk>,
	Linux Kernel list <linux-kernel@...r.kernel.org>,
	Andrew Victor <andrew@...people.com>,
	Andreas Beier <mughat@...il.com>,
	Hamish Guthrie <hamish@...digi.ch>, wux@...dicorp.com,
	Patrice Vilchez <patrice.vilchez@....atmel.com>
Subject: Re: [PATCH] mmc: at91_mci: fix hanging and rework to match flowcharts

On Monday 02 July 2007 14:16, Nicolas Ferre wrote:
> Fixes hanging using multi block operations (seen during CMD25).
> Signed-off-by: Nicolas Ferre <nicolas.ferre@....atmel.com>
Verified working on at91rm9200 using 1 wire mode.

A small remark, only for future improvements:
> @@ -817,7 +834,11 @@ static int __init at91_mci_probe(struct 
>  
>  	mmc->ops = &at91_mci_ops;
>  	mmc->f_min = 375000;
> -	mmc->f_max = 25000000;
> +	if (cpu_is_at91sam9263())
> +		mmc->f_max = 50000000;
> +	else
> +		mmc->f_max = 25000000;
for at91rm9200 f_max is MCK/2 why don't use it?

Nice work, thanks

Regards

Marc
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/