linux-kernel - Re: [PATCH] genericserial: Remove bogus optimisation check and dead code paths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 3 Jul 2007 23:31:35 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Morten Helgesen <morten@...rcepoet.org>
Cc:	akpm@...l.org, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org
Subject: Re: [PATCH] genericserial: Remove bogus optimisation check and dead
 code paths

On Tue, 03 Jul 2007 23:36:22 +0200
Morten Helgesen <morten@...rcepoet.org> wrote:


>  /*
>  > Problems to take into account are:
>  >       -1- Interrupts that empty part of the buffer.
> ->       -2- page faults on the access to userspace. 
> +>       -2- Page faults on access to userspace. 

#2 no longer applies (don't before the caller)
>  >       -3- Other processes that are also trying to do a "write".   
#3 no longer applies (locked by tty layer)

> -	/* get exclusive "write" access to this port (problem 3) */
> +	/* Get exclusive "write" access to this port (problem 3) */
>  	/* This is not a spinlock because we can have a disk access (page 
> -		 fault) in copy_from_user */

No copy_from_user any more. Actually that locking code wants review and
maybe removal so is another project altogether


Definitely an improvement

Acked-by: Alan Cox <alan@...hat.com>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/