| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 12 Jul 2007 10:06:17 +0900 (JST) From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@...ux-ipv6.org> To: gregkh@...e.de Cc: linux-kernel@...r.kernel.org, htejun@...il.com, yoshfuji@...ux-ipv6.org Subject: Re: [PATCH 24/61] sysfs: make sysfs_put() ignore NULL sd In article <20070711235529.GA7485@...e.de> (at Wed, 11 Jul 2007 16:55:29 -0700), Greg KH <gregkh@...e.de> says: > On Thu, Jul 12, 2007 at 08:50:47AM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@ wrote: > > In article <11841968512510-git-send-email-gregkh@...e.de> (at Wed, 11 Jul 2007 16:31:43 -0700), Greg Kroah-Hartman <gregkh@...e.de> says: > > > > > Make sysfs_put() ignore NULL sd instead of oopsing. > > > > I do not think this is a good idea; it is non-sense (and rather a bug) > > to call "put" with NULL argument in general. > > It's better than having to check it all the time in the caller :) How many callers do we have that will get benefit from this change? Well, the change will hide the bug. It seems all callers in fs/sysfs already assume that the argument is NOT NULL, and it is a bug to call sysfs_put() with NULL; the function should be used to "put" something you "have" (non-NULL). If it is called with NULL, I would say, we should BUG here to detect the logical bug. --yoshfuji - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists