linux-kernel - Re: [GIT PATCH] USB patches for 2.6.22

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 12 Jul 2007 17:03:46 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Greg KH <gregkh@...e.de>, Jens Axboe <jens.axboe@...cle.com>,
	Jan Engelhardt <jengelh@...putergmbh.de>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-usb-devel@...ts.sourceforge.net
Subject: Re: [GIT PATCH] USB patches for 2.6.22

On Thu, 12 Jul 2007, Greg KH wrote:
>
> Here are a bunch of USB patches and fixes against your 2.6.22 git tree.

This also seems to contain some *totally*pointless* config variable 
changes, that actually break simple things like "make oldconfig".

This commit is insane: acb11c8b8020f1f1b2545152020675ef32d09a58 "USB: fix 
gregkh-usb-usb-use-menuconfig-objects"

It fixes nothing at all, quite the reverse. It makes the default be 
somethign that breaks everything, and more irritatingly, even if you 
answer 'y' (against the default), it breaks "make oldconfig", which will 
have ignored all the old options and now will ask you for all of them 
again.

Yeah, that second part may be a "make oldconfig" bug, but regardless, 
these kinds of Kconfig changes are BAD, BAD, BAD!

I hate how people do just stupid things to "clean up" config files 
(renaming config options etc), apparently never even bothering to think 
about whether a question is sane or not, or whether normal users want to 
see it or not.

I know I'm not the only one who does "make oldconfig". Answering the same 
questions over and over again is not something *anybody* wants to do.

So please stop this madness. I've reverted the change that left the 
menuconfig entry without a default, which at least fixes "make oldconfig", 
but I just found this really irritating. I can pretty much guarantee that 
nobody actually *tested* this change, did they?

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/