linux-kernel - [PATCH] Kprobes - no kprobes_mutex needed around arch_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 14 Jul 2007 15:56:49 -0400
From:	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
To:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Cc:	prasanna@...ibm.com, ananth@...ibm.com,
	anil.s.keshavamurthy@...el.com, davem@...emloft.net,
	hch@...radead.org
Subject: [PATCH] Kprobes - no kprobes_mutex needed around arch_remove_kprobe calls

Kprobes - no kprobes_mutex needed around arch_remove_kprobe calls.

Since we have the new insn pages mutex, there is no need to protect
arch_remove_kprobe() with the kprobes_mutex anymore. We don't edit the
kernel text there neither, so don't take the text edit lock.

This patch applies after
text-edit-lock-kprobes-architecture-independent.patch

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
CC: hch@...radead.org
CC: prasanna@...ibm.com
CC: ananth@...ibm.com
CC: anil.s.keshavamurthy@...el.com
CC: davem@...emloft.net
---
 kernel/kprobes.c |    4 ----
 1 file changed, 4 deletions(-)

Index: linux-2.6-lttng/kernel/kprobes.c
===================================================================
--- linux-2.6-lttng.orig/kernel/kprobes.c	2007-07-14 15:44:57.000000000 -0400
+++ linux-2.6-lttng/kernel/kprobes.c	2007-07-14 15:45:49.000000000 -0400
@@ -663,11 +663,7 @@ valid_p:
 			list_del_rcu(&p->list);
 			kfree(old_p);
 		}
-		mutex_lock(&kprobe_mutex);
-		kernel_text_lock();
 		arch_remove_kprobe(p);
-		kernel_text_unlock();
-		mutex_unlock(&kprobe_mutex);
 	} else {
 		mutex_lock(&kprobe_mutex);
 		if (p->break_handler)

-- 
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/