linux-kernel - Re: [PATCH 2/3] KVM - Fix hypercall arguments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Jul 2007 11:15:26 +0300
From:	Avi Kivity <avi@...ranet.com>
To:	Anthony Liguori <aliguori@...ibm.com>
CC:	Jeff Dike <jdike@...toit.com>, LKML <linux-kernel@...r.kernel.org>,
	KVM devel <kvm-devel@...ts.sourceforge.net>
Subject: Re: [PATCH 2/3] KVM - Fix hypercall arguments

Jeff Dike wrote:
> It looks like kvm_hypercall is trying to match the system call
> convention and mixed up the call number and first argument in the
> 32-bit case.
>
> Signed-off-by: Jeff Dike <jdike@...ux.intel.com>
> --
>  drivers/kvm/kvm_main.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: kvm/drivers/kvm/kvm_main.c
> ===================================================================
> --- kvm.orig/drivers/kvm/kvm_main.c
> +++ kvm/drivers/kvm/kvm_main.c
> @@ -1351,8 +1351,8 @@ int kvm_hypercall(struct kvm_vcpu *vcpu,
>  	} else
>  #endif
>  	{
> -		nr = vcpu->regs[VCPU_REGS_RBX] & -1u;
> -		a0 = vcpu->regs[VCPU_REGS_RAX] & -1u;
> +		nr = vcpu->regs[VCPU_REGS_RAX] & -1u;
> +		a0 = vcpu->regs[VCPU_REGS_RBX] & -1u;
>  		a1 = vcpu->regs[VCPU_REGS_RCX] & -1u;
>  		a2 = vcpu->regs[VCPU_REGS_RDX] & -1u;
>  		a3 = vcpu->regs[VCPU_REGS_RSI] & -1u;
>   

Anthony?  I think you were hacking this area?

-- 
error compiling committee.c: too many arguments to function

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/