linux-kernel - Re: [Xen-devel] [patch 03/44] usermodehelper: split setup from execution

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 16 Jul 2007 17:57:34 -0700
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Rusty Russell <rusty@...tcorp.com.au>
CC:	Jeremy Fitzhardinge <jeremy@...source.com>,
	Linus Torvalds <torvalds@...ux-foundation.com>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Xen-devel <xen-devel@...ts.xensource.com>,
	Bj?rn Steinbrink <B.Steinbrink@....de>,
	Andi Kleen <ak@...e.de>, lkml <linux-kernel@...r.kernel.org>,
	David Howells <dhowells@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.com>
Subject: Re: [Xen-devel] [patch 03/44] usermodehelper: split setup from	execution

Rusty Russell wrote:
> The patch seems fine, but the names are awkward.  They've always been
> awkward (it's *userspace* helper, not *usermode* helper), but this just
> shines a bright light on them.
>
> So how about:
>
> 	call_usermodehelper_setup -> create_userspace_helper
> 	call_usermodehelper_<SET_EXTRA_STATE> -> userspace_helper_...
> 	call_usermodehelper_exec -> run_userspace_helper
>
> I can do that as a separate patch if you prefer (but it'd be nice to
> have it in the same merge window so the interface only churns once).

I don't have any particular objection, but I think it would be nicer if
they had a common prefix so that they're obviously related, and you can
easily infer the lifetime of the info structure.

    J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/