lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 16 Jul 2007 21:12:26 -0400 From: Jeff Garzik <jeff@...zik.org> To: Andrew Morton <akpm@...ux-foundation.org> CC: FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>, Jens Axboe <jens.axboe@...cle.com>, linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org Subject: Re: block/bsg.c Andrew Morton wrote: > Yup, but the concern (from Al, iirc) was that someone could change the code > later on, add a new bug and have that bug hidden by the unneeded > initialisation. True. That's why #gccbug went the safe route, took the cost of extra instructions, and initialized it to zero. > uninitialized_var() has the advantage that it generates no code, whereas "= > 0" often adds instructions. Plus of course it is self-documenting, greppable-for > and centrally alterable. Agreed. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists