linux-kernel - Re: [PATCH] x86: make SMP locks handling interact properly with CONFIG_DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 18 Jul 2007 07:00:56 +0100
From:	"Jan Beulich" <jbeulich@...ell.com>
To:	"Andi Kleen" <ak@...e.de>
Cc:	"Andrew Morton" <akpm@...ux-foundation.org>,
	<linux-kernel@...r.kernel.org>, <patches@...-64.org>
Subject: Re: [PATCH] x86: make SMP locks handling interact properly
	with CONFIG_DEBUG_RODATA (2nd try)

>>  void alternatives_smp_module_del(struct module *mod)
>>  {
>>  	struct smp_alt_module *item;
>> -	unsigned long flags;
>>  
>>  	if (smp_alt_once || noreplace_smp)
>>  		return;
>>  
>> -	spin_lock_irqsave(&smp_alt, flags);
>> +	spin_lock(&smp_alt);
>
>Unrelated change?  Why? Should probably be separate patch.

Absolutely not: You can't call change_page_attr(), or more precisely
global_flush_tlb(), with interrupts disabled. And since interrupt disabling
is unneeded here afaics, I simply changed the calls instead of inventing
some ugly workaround.

I'll do the other adjustments you asked for, but it'll be only in about three
weeks from now...

Jan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/