linux-kernel - __pdflush have an unnecessary code ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 19 Jul 2007 23:10:26 +0900
From:	barrios <barrioskmc@...il.com>
To:	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Cc:	akpm@...ux-foundation.org
Subject: __pdflush have an unnecessary code ?

When pdflush kernel thread is died, Why do it store current jiffies in
when_i_went_to_sleep variable ?
IMHO, __pdflush function have an unnecessary code although it is trivial.
If my thought is wrong, please give me a answer.

---
 mm/pdflush.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/mm/pdflush.c b/mm/pdflush.c
index 8f6ee07..96aa1da 100644
--- a/mm/pdflush.c
+++ b/mm/pdflush.c
@@ -153,7 +153,6 @@ static int __pdflush(struct pdflush_work *my_work)
                pdf = list_entry(pdflush_list.prev, struct pdflush_work, list);
                if (jiffies - pdf->when_i_went_to_sleep > 1 * HZ) {
                        /* Limit exit rate */
-                       pdf->when_i_went_to_sleep = jiffies;
                        break;                                  /* exeunt */
                }
        }
--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/