linux-kernel - Re: [PATCH 1/2] run scripts/Lindent on it to match Documentation/CodingStyle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 20 Jul 2007 18:36:02 +0100
From:	Simon Arlott <simon@...e.lp0.eu>
To:	Matthew Wilcox <matthew@....cx>
CC:	Denis Cheng <crquan@...il.com>, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] run scripts/Lindent on it to match Documentation/CodingStyle

On 20/07/07 18:07, Matthew Wilcox wrote:
> Of course, we can't add this flag to Lindent until it's widely
> circulating amongst the distributions.  Perhaps we can add this to
> Lindent in the meantime:
> 
> sed -i -e 's/^\t*      \(\w*:\)/ \1/' "$@"
> 
> which will replace the leading tabs and spaces with one space.
> It should leave case labels unmolested, as they should be indented with
> tabs, not 6 spaces.

... isn't the space thing a workaround for a "diff -p" bug?

Labels should either not have any indent or be indented by tabs (since
some code could presumably benefit from indenting labels). Mass
replacing any labels run through Lindent with space prefixes would seem
like a bad idea :/

(From original reply)
It has a habit of leaving/creating "^\t+ +" too, and that "\t\t/*
comment */$" oddity, I couldn't see any options in the man page to fix
those...

-- 
Simon Arlott
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/