lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 20 Jul 2007 09:52:49 +0530 From: "Satyam Sharma" <satyam.sharma@...il.com> To: "Neil Brown" <neilb@...e.de> Cc: "J. Bruce Fields" <bfields@...ldses.org>, "Andrew Morton" <akpm@...ux-foundation.org>, nfs@...ts.sourceforge.net, linux-kernel@...r.kernel.org Subject: Re: [NFS] [PATCH 013 of 20] knfsd: nfsd: factor out code from show_expflags On 7/20/07, Neil Brown <neilb@...e.de> wrote: > On Thursday July 19, bfields@...ldses.org wrote: > > On Thu, Jul 19, 2007 at 10:16:14AM +1000, Neil Brown wrote: > > > On Wednesday July 18, bfields@...ldses.org wrote: > > > > OK, here I'm still confused--what should we be doing instead? > > > > > > Cast the variable to a type that printf knows about. > > > seq_printf(m, ",anonuid=%d", (int)anonu); > > > > > > Or maybe cast it to (long) and use %ld, just in case... > > > > OK. In the event that uid_t some day ceases to eventually become an > > int, will the casts help, or will they just suppress useful warnings? > > Probably not. Just leave it as it is. > > > > > > Note the stray 's' in the current patch, after the comma! > > > > Sharp eyes, thanks! I'll make a patch. Uh, any objection if I print > > all those uid's as unsigned while I'm at it? > > I wondered about that too. I think we have completely removed the > fiction that 'nobody' is '-2' rather than '65534' so it should be both > safe and sensible to make them unsigned. Ummm ... sorry for butting in here :-) But uid_t is always unsigned, yes. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists