linux-kernel - Re: [PATCH] compat_ioctl requires CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 21 Jul 2007 10:40:52 +0200
From:	Sebastian Siewior <sebastian@...akpoint.cc>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] compat_ioctl requires CONFIG_BLOCK

* Arnd Bergmann | 2007-07-21 01:08:57 [+0200]:

>On Saturday 21 July 2007, Sebastian Siewior wrote:
>> 
>> Got with randconfig
>> include/linux/loop.h:66: error: expected specifier-qualifier-list before
>> 'request_queue_t'
>> make[1]: *** [fs/compat_ioctl.o] Error 1
>> 
>> parts of compat ioctl require CONFIG_BLOCK to be set.
>> 
>> Signed-off-by: Sebastian Siewior <sebastian@...akpoint.cc>
>> Index: b/fs/compat_ioctl.c
>> ===================================================================
>> --- a/fs/compat_ioctl.c
>> +++ b/fs/compat_ioctl.c
>> @@ -63,7 +63,9 @@
>>  #include <linux/wireless.h>
>>  #include <linux/atalk.h>
>>  #include <linux/blktrace_api.h>
>> +#ifdef CONFIG_BLOCK
>>  #include <linux/loop.h>
>> +#endif
>
>Adding #ifdef around an #include is considered bad style. Better just
>make loop.h compile without any conditionals. Does the below
>patch work for you?
>
Yes it does.

>	Arnd <><

Sebastian

>
>--- a/include/linux/loop.h
>+++ b/include/linux/loop.h
>@@ -63,7 +63,7 @@ struct loop_device {
> 	struct task_struct	*lo_thread;
> 	wait_queue_head_t	lo_event;
> 
>-	request_queue_t		*lo_queue;
>+	struct request_queue	*lo_queue;
> 	struct gendisk		*lo_disk;
> 	struct list_head	lo_list;
> };

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/