linux-kernel - Re: [patch 3/3] scsi: wd33c93 needs <asm/irq.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 Jul 2007 00:34:03 +0100
From:	Al Viro <viro@....linux.org.uk>
To:	Matthew Wilcox <matthew@....cx>
Cc:	Sergei Shtylyov <sshtylyov@...mvista.com>,
	Christoph Hellwig <hch@...radead.org>,
	Ralf Baechle <ralf@...ux-mips.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-m68k@...r.kernel.org, linux-kernel@...r.kernel.org,
	"James E.J. Bottomley" <James.Bottomley@...elEye.com>,
	linux-scsi@...r.kernel.org, linux-mips@...ux-mips.org
Subject: Re: [patch 3/3] scsi: wd33c93 needs <asm/irq.h>

On Fri, Jul 20, 2007 at 11:50:50AM -0600, Matthew Wilcox wrote:
> On Fri, Jul 20, 2007 at 09:43:47PM +0400, Sergei Shtylyov wrote:
> > Hello Christoph:
> > 
> > >>>+#include <asm/irq.h>
> > 
> > >>These days that should probably be <linux/irq.h>.
> > 
> > >Not at all, linux/irq.h is something entirely different.
> > 
> >    Actually, <linux/interrupt.h>
> 
> Not for enable/disable_irq.  For request_irq, yes.
> 
> This is something that should be fixed.

Now it is...  FWIW, I suspect that absolute majority of asm/irq.h
uses can be removed now.

Next steps in irq.h/interrupt.h cleanups:
	* scouring asm/irq.h like it had been done for sparc32;
the parts that are only used by relevant arch/ code should be
taken there and includes _in_ asm/irq.h trimmed to minimum
	* separating tasklet.h, with interrupt.h still including it.
Using it where needed.
	* asm/softirq.h (with stuff mostly taken there from asm/hardirq.h)
and linux/softirq.h; again interrupt.h still should include it.
	* mechanical adding include of linux/interrupt.h to files that use
request_irq/free_irq/enable_irq/disable_irq/irqreturn_t/IRQF_...
---> in the next merge window:
	* replace include of linux/interrupt.h in netdevice.h with
that of linux/softirq.h.
	* trim uses of linux/interrupt.h that are not needed anymore.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/