linux-kernel - Re: [DRIVER SUBMISSION] DRBD wants to go mainline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 Jul 2007 11:00:38 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Christoph Hellwig <hch@...radead.org>,
	Kyle Moffett <mrlinuxman@....com>,
	Lars Ellenberg <lars@...bit.com>, Jens Axboe <axboe@...nel.dk>,
	Andrew Morton <akpm@...l.org>,
	lkml <linux-kernel@...r.kernel.org>, drbd-user@...bit.com
Subject: Re: [DRIVER SUBMISSION] DRBD wants to go mainline

On Mon, Jul 23, 2007 at 09:49:03AM +0100, Christoph Hellwig wrote:
> On Sun, Jul 22, 2007 at 09:32:02PM -0400, Kyle Moffett wrote:
> > First of all, if you could break this up into chunks (even if they
> > aren't useful individually) just to make it easier to review.
> 
> No, please don't do that I have no idea why people say that except for
> drinking too much "small patches" koolaid.

It is much more preferred to have code available in the mailer than
being forced to copy it from some big patch somewhere when you
want to point out something.

Obviously the big picture is needed too. But the introductory mail
describing the overall design and functionality should provide most of this.
This submission obviously also failed to provide such an overall design intro.

> If a driver is too large for lkml a
> pointer to a large patch is much much better for a proper review.
Then we should request both...

	Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/