linux-kernel - Re: [DRIVER SUBMISSION] DRBD wants to go mainline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 Jul 2007 11:19:40 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Christoph Hellwig <hch@...radead.org>,
	Kyle Moffett <mrlinuxman@....com>,
	Lars Ellenberg <lars@...bit.com>, Jens Axboe <axboe@...nel.dk>,
	Andrew Morton <akpm@...l.org>,
	lkml <linux-kernel@...r.kernel.org>, drbd-user@...bit.com
Subject: Re: [DRIVER SUBMISSION] DRBD wants to go mainline

On Mon, Jul 23, 2007 at 10:01:01AM +0100, Christoph Hellwig wrote:
> On Mon, Jul 23, 2007 at 11:00:38AM +0200, Sam Ravnborg wrote:
> > On Mon, Jul 23, 2007 at 09:49:03AM +0100, Christoph Hellwig wrote:
> > > On Sun, Jul 22, 2007 at 09:32:02PM -0400, Kyle Moffett wrote:
> > > > First of all, if you could break this up into chunks (even if they
> > > > aren't useful individually) just to make it easier to review.
> > > 
> > > No, please don't do that I have no idea why people say that except for
> > > drinking too much "small patches" koolaid.
> > 
> > It is much more preferred to have code available in the mailer than
> > being forced to copy it from some big patch somewhere when you
> > want to point out something.
> 
> While that's a valid point I totally agree on for small patches it just
> doesn't matter for a complex driver where you need to sit down for an
> hour or more to actually do a useful review.

We do review on different levels.
I for once will look at the Makefile + Kconfig bits and some trivial
CodingStyle issues. Here it will help.
You on the other hand I assume will look at the functionality and overall
design and then for you the full patch is the best way.

Well I could try to do the same as you but that would take me maybe
10 hours or more just to come up with some limited input on the overall design.
So therefore instead of backing out I give inputs on the smaller scale
which I know is less usefull but in the hope that this can be resolved
so when you or others take your time to review at least the majority
of the simple CodingStyle things are fixed so you do not get sidetracked
and can concentrate on the important bits.

The message is quite clear.
For a driver like this do something like:
- Describe the functionality / the problem is solved
- Describe the overall design (maybe as a file in Documentation/?)
- Make a single patch available
- Submit mails in smaller chunks for on-the-list reviews

This will then be useable bot for the "triviality" reviewers like me
and for the "knowledge able" reviewers like you.

	Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/