linux-kernel - Re: CTL_UNNUMBERED (Re: [PATCH] 9p: Don't use binary sysctl numbers.)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 Jul 2007 12:13:45 -0500
From:	"Eric Van Hensbergen" <ericvh@...il.com>
To:	lucho@...kov.net
Cc:	"Alexey Dobriyan" <adobriyan@...il.com>,
	linux-kernel@...r.kernel.org,
	"V9FS Developers" <v9fs-developer@...ts.sourceforge.net>,
	"Eric W. Biederman" <ebiederm@...ssion.com>
Subject: Re: CTL_UNNUMBERED (Re: [PATCH] 9p: Don't use binary sysctl numbers.)

On 7/21/07, Eric W. Biederman <ebiederm@...ssion.com> wrote:
> Alexey Dobriyan <adobriyan@...il.com> writes:
>
> >
> > That's separate patch but CTL_UNNUMBERED must die, because it's totally
> > unneeded. If you don't want sysctl(2) interface just SKIP ->ctl_name
> > initialization and save one line for something useful.
>
> As for the 9p code it doesn't seem to need or want a real binary
> interface.  The 9p debug code picking of a semi-random number and not
> patching it into sysctl.h like it should for a binary interface is
> an implementation bug, and a maintenance problem.
>

Now that -rc1 is out, lets talk a bit more about this.  Lucho can you
provide some level of justification of why you went for a sysctl
interface versus something directly accessible within the file system
-- that would seem more on-par with the 9p philosophy.

Perhaps its time for a general cleanup of the debug_level stuff -- it
was always ugly to have it as a global, but there was just no clear
way to have the session structure available everywhere we use it.

               -eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/