linux-kernel - Re: [PATCH] update checkpatch.pl to version 0.08

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 Jul 2007 01:13:11 +0200
From:	"Jesper Juhl" <jesper.juhl@...il.com>
To:	"Andy Whitcroft" <apw@...dowen.org>
Cc:	"Andrew Morton" <akpm@...l.org>,
	"Randy Dunlap" <rdunlap@...otime.net>,
	"Joel Schopp" <jschopp@...tin.ibm.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] update checkpatch.pl to version 0.08

On 15/07/07, Andy Whitcroft <apw@...dowen.org> wrote:
>
> This version brings a number of new checks, and a number of bug
> fixes.  Of note:
>
>   - warnings for multiple assignments per line
>   - warnings for multiple declarations per line
>   - checks for single statement blocks with braces
>
> This patch includes an update for feature-removal-schedule.txt to
> better target checks.
>
> Andy Whitcroft (12):
>       Version: 0.08
>       only apply printk checks where there is a string literal
>       allow suppression of errors for when no patch is found
>       warn about multiple assignments
>       warn on declaration of multiple variables
>       check for kfree() with needless null check

It's not just kfree(), it's a whole list of functions, like kfree(),
vfree(), crypto_free_tfm() and a bunch of other freeing functions...


>       check for single statement braced blocks

Hmmm, if the single statement is a macro, braces sometimes make a lot
of sense...


Suggested further improvement; check that patches don't modify files
listed in Documentation/dontdiff


-- 
Jesper Juhl <jesper.juhl@...il.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/