linux-kernel - Re: [PATCH] update checkpatch.pl to version 0.08

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 Jul 2007 02:15:26 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Andy Whitcroft <apw@...dowen.org>
Cc:	"Kok, Auke" <auke-jan.h.kok@...el.com>,
	Randy Dunlap <rdunlap@...otime.net>,
	Joel Schopp <jschopp@...tin.ibm.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] update checkpatch.pl to version 0.08

On Tue, 24 Jul 2007 10:06:51 +0100 Andy Whitcroft <apw@...dowen.org> wrote:

> > This is a royal pain, since it now throws an ERROR for the obviously
> > preferable piece of code below:
> > 
> > if (err) {
> >     do_something();
> >     return -ERR;
> > } else {
> >     do_somthing_else();
> > }
> 
> Hmmm, is that obviouly nicer than the below?  Its fully a line longer
> for no benefit.  But ignoring that, this seems to have snuck in to
> CodingStyle hmmm ... will see what I can do if anything to stop these
> being picked up I guess.
> 
> 	if (err) {
> 		do_something();
> 		return -ERR;
> 	} else
> 		do_something_else();

The kool kids on linux-usb-devel largely ended up deciding that the second
version looks dorky.

Especially if there's a comment over do_something_else(), and if there's
not a comment, perhaps there should be?

> Andrew, as you merged the change to CodingStyle I'll take that as your
> being ok with these being accepted.

It's very marginal and is sure to get people hot and bothered.  I'd suggest
that checkpatch be neutral on that.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/