linux-kernel - Re: [PATCH 3/3] core_pattern: fix up a few miscelaneous bugs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 29 Jul 2007 21:03:35 +0800
From:	Eugene Teo <eteo@...hat.com>
To:	Neil Horman <nhorman@...driver.com>
CC:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	jeremy@...p.org, martin.pitt@...ntu.com, wwoods@...hat.com
Subject: Re: [PATCH 3/3] core_pattern: fix up a few miscelaneous bugs

Neil Horman wrote:
[...]
> +		delimit = strrchr(helper_argv[0], '/');
> +		if (delimit) 

Trailing space.

> +			delimit++;
> +		else
> +			delimit = helper_argv[0];
> +		if (!strcmp(delimit, current->comm))
> +		{	

Trailing space, and '{' should be after '...comm))'.

Eugene
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/