linux-kernel - Re: commit 7e92b4fc34 - x86, serial: convert legacy COM ports to platform devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 29 Jul 2007 19:03:07 +0100
From:	Russell King <rmk+lkml@....linux.org.uk>
To:	Bjorn Helgaas <bjorn.helgaas@...com>
Cc:	Shaohua Li <shaohua.li@...el.com>,
	Yinghai Lu <yhlu.kernel@...il.com>,
	Sébastien Dugué <sebastien.dugue@...l.net>,
	linux-kernel <linux-kernel@...r.kernel.org>, ambx1@....rr.com,
	akpm@...ux-foundation.org, lenb@...nel.org, mjg59@...f.ucam.org,
	castet.matthieu@...e.fr
Subject: Re: commit 7e92b4fc34 - x86, serial: convert legacy COM ports to platform devices - broke my serial console

On Fri, Jul 27, 2007 at 12:16:59PM -0600, Bjorn Helgaas wrote:
> For example, 8250_pnp could have rules like "COM1 should always
> be ttyS0" or "a port at 0x3f8 should always be ttyS0."

In which case register via the legacy ports first, and then register
PNP ports.  If the PNP ports correspond with legacy ports, they will
re-use those slots.

So, if we register 0x3f8 first (which ends up as ttyS0), followed by
0x2f8 (ttyS1) and then PNP tries to register a port at 0x2f8 then
0x3f8, you'll still end up with 0x3f8 being ttyS0 and 0x2f8 as ttyS1.

> That doesn't help with Yinghai's PCI root ordering issue, of course.
> But I hope that can be addressed with udev, because there's not so
> much need for a persistent kernel name.  If that's not enough, can
> you explain more about the problem?

However, aren't PNP serial ports attached to separate PNP devices?  If
so, udev can work it out already - they just need to look at the
backing device associated with the serial port.  For legacy ports that'll
be serial8250.0.  For PNP, it'll be some PNP device.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/