linux-kernel - Re: [PATCH 2/3] core_pattern: allow passing of arguments to user mode helper when core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 29 Jul 2007 17:58:16 -0400
From:	Neil Horman <nhorman@...driver.com>
To:	Eugene Teo <eteo@...hat.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	jeremy@...p.org, martin.pitt@...ntu.com, wwoods@...hat.com
Subject: Re: [PATCH 2/3] core_pattern: allow passing of arguments to user mode helper when core_pattern is a pipe

On Sun, Jul 29, 2007 at 09:03:29PM +0800, Eugene Teo wrote:
> Neil Horman wrote:
> [...]
> > +			/* core limit size */
> > +			case 'c':
> > +				rc = snprintf(out_ptr, out_end - out_ptr,
> > +					      "%lu", current->signal->rlim[RLIMIT_CORE].rlim_cur); 
> 
> Trailing space.
> 
> [...]
> > - 		if(call_usermodehelper_pipe(corename+1, NULL, NULL, &file)) {
> > + 		if(call_usermodehelper_pipe(corename+1, helper_argv, NULL, &file)) {
>    ^^^^^^^^^^^^^
> 
> Use tabs, and a missing space after '('.
> 
I think your reader is screwing up the patch.  The version that I sent, which I
have here, shows that as all tabs, no spaces.

As for the '(', yeah, that looks like its been there for awhile.  I'll clean it
all up when I address macro expansion, as per the conversation Martin and I have
been holding.

Regards
Neil
 
> Eugene

-- 
/***************************************************
 *Neil Horman
 *Software Engineer
 *Red Hat, Inc.
 *nhorman@...driver.com
 *gpg keyid: 1024D / 0x92A74FA1
 *http://pgp.mit.edu
 ***************************************************/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/