linux-kernel - Re: [PATCH] bsg: Fix warning with CONFIG_BLK_DEV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 29 Jul 2007 12:54:58 +0200
From:	Jens Axboe <jens.axboe@...cle.com>
To:	Roland Dreier <rdreier@...co.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bsg: Fix warning with CONFIG_BLK_DEV_BSG=n

On Sat, Jul 28 2007, Roland Dreier wrote:
> The current stub definitions of bsg_register_queue() and
> bsg_unregister_queue() as macros leads to
> 
>     drivers/scsi/scsi_sysfs.c: In function 'scsi_sysfs_add_sdev':
>     drivers/scsi/scsi_sysfs.c:718: warning: unused variable 'rq'
> 
> because the first parameter of bsg_register_queue() is completely
> discarded.  As akpm says, "program in C, not in cpp."  We might as
> well get a little bit better type-checking when we fix this by
> converting the stubs to empty inline functions.

James should already have that patch queued for inclusion since last
week.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/