linux-kernel - RE: [PATCH 3/5 v3] Add the platform device support with RapidIO to MPC8641HPCN platform.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 30 Jul 2007 16:26:32 +0800
From:	"Zhang Wei-r63237" <Wei.Zhang@...escale.com>
To:	"Arnd Bergmann" <arnd@...db.de>, <linuxppc-dev@...abs.org>
Cc:	<galak@...nel.crashing.org>, <mporter@...nel.crashing.org>,
	<paulus@...ba.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 3/5 v3] Add the platform device support with RapidIO to MPC8641HPCN platform.

Hi, Arnd,

I can change it as you metioned now.

Thanks!
-zw

> -----Original Message-----
> From: linux-kernel-owner@...r.kernel.org 
> [mailto:linux-kernel-owner@...r.kernel.org] On Behalf Of Arnd Bergmann
> Sent: Sunday, July 29, 2007 9:57 PM
> To: linuxppc-dev@...abs.org
> Cc: Zhang Wei-r63237; galak@...nel.crashing.org; 
> mporter@...nel.crashing.org; paulus@...ba.org; 
> linux-kernel@...r.kernel.org
> Subject: Re: [PATCH 3/5 v3] Add the platform device support 
> with RapidIO to MPC8641HPCN platform.
> 
> On Thursday 26 July 2007, Zhang Wei wrote:
> > +
> > +static struct of_device_id mpc86xx_of_ids[] = {
> > +       { .type = "soc", },
> > +       { .compatible = "fsl,rapidio-delta", },
> > +       {},
> > +};
> 
> With the device tree source you have posted in 2/5, the 
> rapidio node is
> a child of the soc bus, and it doesn't have any children of its own.
> Therefore it is completely equivalent to _only_ add the soc type
> to mpc86xx_of_ids[], as in 
> 
> static struct of_device_id mpc86xx_of_ids[] = {
>        { .type = "soc", },
>        {},
> };
> 
> Even if you intend to add children to the rapidio node in the future,
> I'd think it would be more appropriate to have those scanned by
> the rapidio bus driver, not by of_platform.
> 
> 	Arnd <><
> 
> -
> To unsubscribe from this list: send the line "unsubscribe 
> linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/