linux-kernel - Re: [PATCH 34] fs/autofs4/inode.c: kmalloc + memset conversion to kzalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 01 Aug 2007 12:02:09 +0800
From:	Ian Kent <raven@...maw.net>
To:	Mariusz Kozlowski <m.kozlowski@...land.pl>
Cc:	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	autofs@...ux.kernel.org
Subject: Re: [PATCH 34] fs/autofs4/inode.c: kmalloc + memset conversion to
	kzalloc

On Tue, 2007-07-31 at 20:05 +0200, Mariusz Kozlowski wrote:
> Signed-off-by: Mariusz Kozlowski <m.kozlowski@...land.pl>

ACK.

> 
>  fs/autofs4/inode.c | 10467 -> 10435 (-32 bytes)
>  fs/autofs4/inode.o | 98576 -> 98552 (-24 bytes)
> 
>  fs/autofs4/inode.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> --- linux-2.6.23-rc1-mm1-a/fs/autofs4/inode.c	2007-07-26 13:07:46.000000000 +0200
> +++ linux-2.6.23-rc1-mm1-b/fs/autofs4/inode.c	2007-07-29 23:56:08.000000000 +0200
> @@ -312,13 +312,11 @@ int autofs4_fill_super(struct super_bloc
>  	struct autofs_sb_info *sbi;
>  	struct autofs_info *ino;
> 
> -	sbi = kmalloc(sizeof(*sbi), GFP_KERNEL);
> +	sbi = kzalloc(sizeof(*sbi), GFP_KERNEL);
>  	if (!sbi)
>  		goto fail_unlock;
>  	DPRINTK("starting up, sbi = %p",sbi);
> 
> -	memset(sbi, 0, sizeof(*sbi));
> -
>  	s->s_fs_info = sbi;
>  	sbi->magic = AUTOFS_SBI_MAGIC;
>  	sbi->pipefd = -1;
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/