linux-kernel - Re: [PATCH][ACPI] Let's not gamble that a possible double free will never happen in asus_hotk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sat, 4 Aug 2007 18:14:05 +0200
From:	"Jesper Juhl" <jesper.juhl@...il.com>
To:	"Len Brown" <lenb@...nel.org>
Cc:	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
	"Julien Lerouge" <julien.lerouge@...e.fr>,
	"Karol Kozimor" <sziwan@...rs.sourceforge.net>,
	linux-acpi@...r.kernel.org, corentincj@...aif.net,
	acpi4asus-user@...ts.sourceforge.net
Subject: Re: [PATCH][ACPI] Let's not gamble that a possible double free will never happen in asus_hotk_get_info()

On 03/08/07, Len Brown <lenb@...nel.org> wrote:
> On Saturday 28 July 2007 18:45, Jesper Juhl wrote:
> > Signed-off-by: Jesper Juhl <jesper.juhl@...il.com>
> > ---
> >
> > drivers/acpi/asus_acpi.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/acpi/asus_acpi.c b/drivers/acpi/asus_acpi.c
> > index 9c4bd22..86fd142 100644
> > --- a/drivers/acpi/asus_acpi.c
> > +++ b/drivers/acpi/asus_acpi.c
> > @@ -1192,6 +1192,7 @@ static int asus_hotk_get_info(void)
> > break;
> > default:
> > kfree(model);
> > +model = NULL;
> > break;
> > }
> > }
>
> applied.
>
> coverity didn't find the bug below this code however.
> we can also leak model in the path that returns  OK.
>
Whoops, I should have spotted that.  I assume you've now fixed that locally?

-- 
Jesper Juhl <jesper.juhl@...il.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/