| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 8 Aug 2007 16:12:41 +0900 From: Tejun Heo <htejun@...il.com> To: "Eric W. Biederman" <ebiederm@...ssion.com> Cc: Greg KH <greg@...ah.com>, linux-kernel@...r.kernel.org, satyam@...radead.org, cornelia.huck@...ibm.com, stern@...land.harvard.edu, Linux Containers <containers@...ts.osdl.org>, gregkh@...e.de Subject: Re: [PATCH 06/25] sysfs: Simplify readdir. On Tue, Aug 07, 2007 at 03:13:14PM -0600, Eric W. Biederman wrote: > > At some point someone wrote sysfs_readdir to insert a cursor > into the list of sysfs_dirents to ensure that sysfs_readdir would > restart properly. That works but it is complex code and tends > to be expensive. > > The same effect can be achieved by keeping the sysfs_dirents in > inode order and using the inode number as the f_pos. Then > when we restart we just have to find the first dirent whose inode > number is equal or greater then the last sysfs_dirent we attempted > to return. > > Removing the sysfs directory cursor also allows the remove of > all of the mysterious checks for sysfs_type(sd) != 0. Which > were nonbovious checks to see if a cursor was in a directory list. > > Signed-off-by: Eric W. Biederman <ebiederm@...ssion.com> Acked-by: Tejun Heo <htejun@...il.com> -- tejun - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists