linux-kernel - Re: [PATCH] Add missing newlines to some uses of dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 7 Aug 2007 20:00:24 -0700
From:	"Nish Aravamudan" <nish.aravamudan@...il.com>
To:	"Joe Perches" <joe@...ches.com>
Cc:	linux-kernel@...r.kernel.org, "Greg KH" <gregkh@...e.de>,
	"Jeff Garzik" <jeff@...zik.org>, "Tony Luck" <tony.luck@...el.com>,
	"Jiri Slaby" <jirislaby@...il.com>,
	"Roland Dreier" <rolandd@...co.com>,
	"David Brownell" <dbrownell@...rs.sourceforge.net>,
	"James Smart" <james.smart@...lex.com>,
	"Hansjoerg Lipp" <hjlipp@....de>,
	"Jean Delvare" <khali@...ux-fr.org>,
	"Mark M. Hoffman" <mhoffman@...htlink.com>,
	"Jeremy Fitzhardinge" <jeremy@...source.com>
Subject: Re: [PATCH] Add missing newlines to some uses of dev_<level> messages

On 8/7/07, Joe Perches <joe@...ches.com> wrote:
> Found these while looking at printk uses.
>
> Add missing newlines to dev_<level> uses
> Add missing KERN_<level> prefixes to multiline dev_<level>s
> Fixed a wierd->weird spelling typo
> Added a newline to a printk

I think these should have been split logically into 4 groups of
patches (except perhaps where they touched the same file for the first
two and the last).

The third type should go through trivial.

And they should have been split logically by subsystem, most likely?

<snip diffstat>

> diff --git a/arch/ia64/sn/kernel/xpnet.c b/arch/ia64/sn/kernel/xpnet.c
> index e58fcad..a5df672 100644
> --- a/arch/ia64/sn/kernel/xpnet.c
> +++ b/arch/ia64/sn/kernel/xpnet.c
> @@ -269,8 +269,9 @@ xpnet_receive(partid_t partid, int channel, struct xpnet_message *msg)
>         skb->protocol = eth_type_trans(skb, xpnet_device);
>         skb->ip_summed = CHECKSUM_UNNECESSARY;
>
> -       dev_dbg(xpnet, "passing skb to network layer; \n\tskb->head=0x%p "
> -               "skb->data=0x%p skb->tail=0x%p skb->end=0x%p skb->len=%d\n",
> +       dev_dbg(xpnet, "passing skb to network layer\n"
> +               KERN_DEBUG "\tskb->head=0x%p skb->data=0x%p skb->tail=0x%p "
> +               "skb->end=0x%p skb->len=%d\n",
>                 (void *)skb->head, (void *)skb->data, skb_tail_pointer(skb),
>                 skb_end_pointer(skb), skb->len);

<snip>

I'm not a maintainer of any code by any means, but it seems odd,
redundant and visually confusing to me to use the dev_dbg() function
and have KERN_DEBUG's inside the string -- makes me question every
time why there isn't one for the first line too.

Perhaps these multi-line debug statements should simply be split into
multiple dev_dbg() calls? Similar for the other dev_ functions. I
think it might look cleaner, at least. Just my two cents, not a NAK or
anything.

Thanks,
Nish
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/