linux-kernel - Re: Are we properly prepared to handle 3 Socket setups?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 12 Aug 2007 22:00:52 +0200
From:	Rene Herman <rene.herman@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	Jesper Juhl <jesper.juhl@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...e.hu>,
	Christoph Lameter <clameter@....com>
Subject: Re: Are we properly prepared to handle 3 Socket setups?

On 08/12/2007 10:35 AM, Andrew Morton wrote:

> On Sun, 12 Aug 2007 05:17:10 +0200 Rene Herman <rene.herman@...il.com> wrote:

>> The line just below where it does that _does_ seem to have a problem:
>>
>>          /*
>>           * Maximum threshold is 125
>>           */
>>          threshold = min(125, threshold);
>>
>> as either the comment or the code is wrong and it seems it's the code. Added 
>> Andrew Morton to the CC for that.
> 
> Yes, that's inconsistent.  And looking at Christoph's df9ecaba it's unclear
> whether the comment is wrong or the code is wrong.  The code is wrong, I
> expect.

Extremely friendly of you to pretend I wasn't being thick at all but don't 
worry, I can take it. Anyways, since Christoph wasn't in CC on that one:

On 08/12/2007 05:29 AM, Roland Dreier wrote:

> What's the problem? That line sets threshold to the smaller of the 
> current value or 125, which is exactly what one would want to do if the
> maximum value is 125. Just do a couple of examples: eg if threshold is
> 100 going into that line, then the value is left alone; if threshold is
> 150 then it gets set to 125; and that seems exactly correct.

Rene.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/