linux-kernel - Re: [PATCH] Fix triplefault on x86-64 bootup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 12 Aug 2007 01:59:16 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Petr Vandrovec <petr@...drovec.name>
cc:	ak@...e.de, discuss@...-64.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix triplefault on x86-64 bootup

On Sun, 12 Aug 2007, Linus Torvalds wrote:
> 
> Hmm. Patch looks ok, I just wonder what started triggering this for you?

Oh. It's the "Make patching more robust" commit.

"Robust" my ass.

We used to just copy the replacement in one go (works fine, since it just 
overwrote the two first bytes), and then "nop_out()" the rest (works fine, 
since it didn't matter for memcpy).

That whole commit looks a bit dubious. It also adds a 254-byte stack 
usage (anything actually even close to that big?). Gaah.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/