linux-kernel - [PATCH 4/6] infiniband: mlx4_MAD_IFC copies out response unconditionally

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 Aug 2007 14:19:01 +0100
From:	Andy Whitcroft <apw@...dowen.org>
To:	linux-kernel@...r.kernel.org
Cc:	Randy Dunlap <rdunlap@...otime.net>, Andrew Morton <akpm@...l.org>,
	Andy Whitcroft <apw@...dowen.org>,
	Andy Whitcroft <apw@...dowen.org>,
	Roland Dreier <rolandd@...co.com>,
	Sean Hefty <mshefty@...ips.intel.com>,
	Hal Rosenstock <hal.rosenstock@...il.com>,
	general@...ts.openfabrics.org
Subject: [PATCH 4/6] infiniband: mlx4_MAD_IFC copies out response unconditionally


It seems a trailing ';' has slipped into mlx4_MAD_IFC() which causes
the response to be copied out unconditionally.

Signed-off-by: Andy Whitcroft <apw@...dowen.org>
Cc: Roland Dreier <rolandd@...co.com>
Cc: Sean Hefty <mshefty@...ips.intel.com>
Cc: Hal Rosenstock <hal.rosenstock@...il.com>
Cc: general@...ts.openfabrics.org
---
 drivers/infiniband/hw/mlx4/mad.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/infiniband/hw/mlx4/mad.c b/drivers/infiniband/hw/mlx4/mad.c
index 3330917..0ed02b7 100644
--- a/drivers/infiniband/hw/mlx4/mad.c
+++ b/drivers/infiniband/hw/mlx4/mad.c
@@ -109,7 +109,7 @@ int mlx4_MAD_IFC(struct mlx4_ib_dev *dev, int ignore_mkey, int ignore_bkey,
 			   in_modifier, op_modifier,
 			   MLX4_CMD_MAD_IFC, MLX4_CMD_TIME_CLASS_C);
 
-	if (!err);
+	if (!err)
 		memcpy(response_mad, outmailbox->buf, 256);
 
 	mlx4_free_cmd_mailbox(dev->dev, inmailbox);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/