lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 15 Aug 2007 19:19:20 -0700 From: "Kok, Auke" <auke-jan.h.kok@...el.com> To: Joe Perches <joe@...ches.com>, Andy Whitcroft <apw@...dowen.org>, "Randy.Dunlap" <rdunlap@...otime.net>, Joel Schopp <jschopp@...tin.ibm.com> CC: Dave Jones <davej@...hat.com>, Linux Kernel <linux-kernel@...r.kernel.org>, rolandd@...co.com, Chas Williams <chas@....nrl.navy.mil>, Paul Mundt <lethal@...ux-sh.org>, isdn4linux@...tserv.isdn4linux.de, mikep@...uxtr.net, netdev@...r.kernel.org, swen@...t.ibm.com, linux390@...ibm.com, linux-s390@...r.kernel.org, jdike@...aya.com, user-mode-linux-devel@...ts.sourceforge.net, user-mode-linux-user@...ts.sourceforge.net, netfilter-devel@...ts.netfilter.org, coreteam@...filter.org Subject: Re: drivers/infiniband/mlx/mad.c misplaced ; Joe Perches wrote: > On Wed, 2007-08-15 at 19:58 -0400, Dave Jones wrote: >> Signed-off-by: Dave Jones <davej@...hat.com> >> >> diff --git a/drivers/infiniband/hw/mlx4/mad.c b/drivers/infiniband/hw/mlx4/mad.c >> index 3330917..0ed02b7 100644 >> --- a/drivers/infiniband/hw/mlx4/mad.c >> +++ b/drivers/infiniband/hw/mlx4/mad.c >> @@ -109,7 +109,7 @@ int mlx4_MAD_IFC(struct mlx4_ib_dev *dev, int ignore_mkey, int ignore_bkey, >> in_modifier, op_modifier, >> MLX4_CMD_MAD_IFC, MLX4_CMD_TIME_CLASS_C); >> >> - if (!err); >> + if (!err) > > There's more than a few of these (not inspected). > > $ egrep -r --include=*.c "\bif[[:space:]]*\([^\)]*\)[[:space:]]*\;" * > arch/sh/boards/se/7343/io.c: if (0) ; > drivers/atm/iphase.c: if (!desc1) ; > drivers/infiniband/hw/mlx4/mad.c: if (!err); > drivers/isdn/capi/capiutil.c: else if (c <= 0x0f); > drivers/net/tokenring/ibmtr.c: else if (ti->shared_ram_paging == 0xf); /* No paging in adapter */ > drivers/s390/scsi/zfcp_erp.c: if (status == ZFCP_ERP_SUCCEEDED) ; /* no further action */ > fs/hostfs/hostfs_user.c: if(attrs->ia_valid & HOSTFS_ATTR_CTIME) ; > net/netfilter/xt_u32.c: if (skb->len < 4 || pos > skb->len - 4); > sound/pci/au88x0/au88x0_synth.c: if (eax == 0) ; sounds like an excellent candidate check for checkpatch.pl !!! Cheers, Auke - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists