linux-kernel - [PATCH] IRDA: Avoid a label defined but not used warning in irda

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 17 Aug 2007 23:22:33 +0200
From:	Jesper Juhl <jesper.juhl@...il.com>
To:	Samuel Ortiz <samuel@...tiz.org>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Dag Brattli <dagb@...uit.no>, Jean Tourrilhes <jt@....hp.com>,
	Jesper Juhl <jesper.juhl@...il.com>
Subject: [PATCH] IRDA: Avoid a label defined but not used warning in irda_init()

Hi,

Easily avoidable compiler warnings bug me.


Building irmod without CONFIG_SYSCTL currently results in : 
 net/irda/irmod.c:132: warning: label 'out_err_2' defined but not used

But that can easily be avoided by simply moving the label inside 
the existing "#ifdef CONFIG_SYSCTL" one line above it.

This patch moves the label and buys us one less warning with no 
ill effects.


Signed-off-by: Jesper Juhl <jesper.juhl@...il.com>
---

 net/irda/irmod.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/irda/irmod.c b/net/irda/irmod.c
index 1900937..8ba703d 100644
--- a/net/irda/irmod.c
+++ b/net/irda/irmod.c
@@ -128,8 +128,8 @@ static int __init irda_init(void)
  out_err_3:
 #ifdef CONFIG_SYSCTL
 	irda_sysctl_unregister();
-#endif
  out_err_2:
+#endif
 #ifdef CONFIG_PROC_FS
 	irda_proc_unregister();
 #endif



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/