| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 17 Aug 2007 21:06:51 -0700 From: David Brownell <david-b@...bell.net> To: Kay Sievers <kay.sievers@...y.org> Cc: Atsushi Nemoto <anemo@....ocn.ne.jp>, jengelh@...putergmbh.de, a.zummo@...ertech.it, linux-kernel@...r.kernel.org, rtc-linux@...glegroups.com, Greg KH <greg@...ah.com> Subject: Re: [PATCH] rtc: Make rtc-ds1742 driver hotplug-aware On Friday 17 August 2007, Kay Sievers wrote: > > > I'm not the one who's advocating a change here. If you want to > > first change/break and then fix things, all of that is up to you. > > I'm happy to do that. Patch is attached. NAK. That wasn't even a serious attempt at the "fix" part, though it does the "break" part well enough to cause severe regressions. (As well as leaving all my technical points about your pushback un-addressed. As I noted before, the evident fact that you don't have technical responses to them says to me that your pushback has no real technical basis ...) Out of around 300 platform drivers in the tree (and many more not yet merged upstream), this makes it so that only *THREE* of them can hotplug ... versus in the current tree, essentially everything that's not a legacy driver is hotplugging just fine. That's one heck of a regression. Just shy of 100% ... Plus it treats rtc-ds1742 as if it's a platform_driver not an i2c_driver. - Dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists