linux-kernel - Re: [PATCH resubmit] /drivers/ata ioremap returncode check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 23 Aug 2007 21:42:04 +0400
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	Brandon Philips <brandon@...p.org>
Cc:	postfail@...hmail.com, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org, linux-ide@...r.kernel.org
Subject: Re: [PATCH resubmit] /drivers/ata ioremap returncode check

On Wed, Aug 22, 2007 at 10:34:58PM -0700, Brandon Philips wrote:
> On 19:47 Wed 22 Aug 2007, Scott Thompson wrote:
> > Patchset against 2.6.23-rc3.  corrects missing ioremap return 
> > checks, resending after making changes suggested....
> > 
> > Signed-off-by: Scott Thompson <postfail <at> hushmail.com>
> > ------------------------------------------------------------
> > diff --git a/drivers/ata/pata_ixp4xx_cf.c b/drivers/ata/pata_ixp4xx_cf.c
> > index 4ca7fd6..8dc7c3b 100644
> > --- a/drivers/ata/pata_ixp4xx_cf.c
> > +++ b/drivers/ata/pata_ixp4xx_cf.c
> > @@ -189,6 +189,10 @@ static __devinit int ixp4xx_pata_probe(struct platform_device *pdev)
> >  	data->cs0 = devm_ioremap(&pdev->dev, cs0->start, 0x1000);
> >  	data->cs1 = devm_ioremap(&pdev->dev, cs1->start, 0x1000);
> >  
> > +	if (!data->cs0 || !data->cs1) {
> > +		return -ENOMEM;
> > +	}
> > +
> 
> You aren't following the Kernel CodingStyle there.  
> 
> See Documentation/CodingStyle:
> 
> "Do not unnecessarily use braces where a single statement will do."
> 
> +	if (!data->cs0 || !data->cs1)
> +		return -ENOMEM;

This and nice printk message absence. :)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/