linux-kernel - Re: [PATCH 22/30] ivtv: kzalloc() returns void pointer, no need to cast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 24 Aug 2007 10:32:14 +0200
From:	Hans Verkuil <hverkuil@...all.nl>
To:	Jesper Juhl <jesper.juhl@...il.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Kevin Thayer <nufan_wfk@...oo.com>,
	Chris Kennedy <c@...ovy.org>, video4linux-list@...hat.com
Subject: Re: [PATCH 22/30] ivtv: kzalloc() returns void pointer, no need to cast

On Friday 24 August 2007 02:20:04 Jesper Juhl wrote:
> Since kzalloc() returns a void pointer, we don't need to cast the
> return value in drivers/media/video/ivtv/ivtv-queue.c
>
> Signed-off-by: Jesper Juhl <jesper.juhl@...il.com>

Jesper,

Thanks for the patch. I've applied it to my latest tree and will ask 
Mauro to pull from it. The latest source is a bit different and has in 
fact a third cast which I've also removed.

Thanks,

	Hans

> ---
>  drivers/media/video/ivtv/ivtv-queue.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/video/ivtv/ivtv-queue.c
> b/drivers/media/video/ivtv/ivtv-queue.c index a04f938..45825b8 100644
> --- a/drivers/media/video/ivtv/ivtv-queue.c
> +++ b/drivers/media/video/ivtv/ivtv-queue.c
> @@ -196,7 +196,7 @@ int ivtv_stream_alloc(struct ivtv_stream *s)
>  		s->name, s->buffers, s->buf_size, s->buffers * s->buf_size /
> 1024);
>
>  	if (ivtv_might_use_pio(s)) {
> -		s->PIOarray = (struct ivtv_SG_element *)kzalloc(SGsize,
> GFP_KERNEL); +		s->PIOarray = kzalloc(SGsize, GFP_KERNEL);
>  		if (s->PIOarray == NULL) {
>  			IVTV_ERR("Could not allocate PIOarray for %s stream\n", s->name);
>  			return -ENOMEM;
> @@ -204,7 +204,7 @@ int ivtv_stream_alloc(struct ivtv_stream *s)
>  	}
>
>  	/* Allocate DMA SG Arrays */
> -	s->SGarray = (struct ivtv_SG_element *)kzalloc(SGsize, GFP_KERNEL);
> +	s->SGarray = kzalloc(SGsize, GFP_KERNEL);
>  	if (s->SGarray == NULL) {
>  		IVTV_ERR("Could not allocate SGarray for %s stream\n", s->name);
>  		if (ivtv_might_use_pio(s)) {


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/