linux-kernel - [PATCH RT] - Mellanox IB driver patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 24 Aug 2007 02:25:26 -0700
From:	Sven-Thorsten Dietrich <sdietrich@...ell.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	"Michael S. Tsirkin" <mst@....mellanox.co.il>,
	LKML <Linux-kernel@...r.kernel.org>,
	RT Users List <linux-rt-users@...r.kernel.org>,
	Linux Solutions Group List <lsg@...ts.novell.com>
Subject: [PATCH RT] - Mellanox IB driver patch


Hi Ingo,

RT driver patch to eliminate in_atomic stack dump.

The problem code was identified by Michael S. Tsirkin, and he suggested
the fix.

I adapted to use RT's _nort primitives- should work correctly in all
configs.

Thanks,

Sven


Fixes in_atomic stack-dump, when Mellanox module 
is loaded into the RT Kernel.

From: Michael S. Tsirkin <mst@....mellanox.co.il> 

"Basically, if you just make spin_lock_irqsave (and spin_lock_irq) not disable
interrupts for non-raw spinlocks, I think all of infiniband will be fine without
changes."

signed-off-by: Sven-Thorsten Dietrich <sven@...bigcorporation.com>


Index: linux-2.6.21/drivers/infiniband/ulp/ipoib/ipoib_multicast.c
===================================================================
--- linux-2.6.21.orig/drivers/infiniband/ulp/ipoib/ipoib_multicast.c
+++ linux-2.6.21/drivers/infiniband/ulp/ipoib/ipoib_multicast.c
@@ -788,7 +788,7 @@ void ipoib_mcast_restart_task(struct wor
 
 	ipoib_mcast_stop_thread(dev, 0);
 
-	local_irq_save(flags);
+	local_irq_save_nort(flags);
 	netif_tx_lock(dev);
 	spin_lock(&priv->lock);
 
@@ -863,7 +863,7 @@ void ipoib_mcast_restart_task(struct wor
 
 	spin_unlock(&priv->lock);
 	netif_tx_unlock(dev);
-	local_irq_restore(flags);
+	local_irq_restore_nort(flags);
 
 	/* We have to cancel outside of the spinlock */
 	list_for_each_entry_safe(mcast, tmcast, &remove_list, list) {


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/